Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/kv): reverse mapping between AnyValue::Bool and KeyPart::Bool #18365

Merged
merged 2 commits into from
Mar 22, 2023
Merged

fix(ext/kv): reverse mapping between AnyValue::Bool and KeyPart::Bool #18365

merged 2 commits into from
Mar 22, 2023

Conversation

losfair
Copy link
Member

@losfair losfair commented Mar 22, 2023 •
edited
Loading

Previously the mapping between AnyValue::Bool and KeyPart::Bool was inverted.

This patch also allows using the empty key [] as range start/end to snapshot_read.

@losfair losfair requested a review from lucacasonato March 22, 2023 20:02
@losfair losfair force-pushed the fix-any-value-to-keypart branch from ccd8bd8 to 49c2607 Compare March 22, 2023 20:10
@bartlomieju bartlomieju added the ci-test-flaky put this on a PR to run concurrent workflows label Mar 22, 2023
@losfair losfair force-pushed the fix-any-value-to-keypart branch from 3ef485d to 655be64 Compare March 22, 2023 20:27
@bartlomieju bartlomieju merged commit 533e331 into denoland:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@lucacasonato lucacasonato Awaiting requested review from lucacasonato

Assignees
No one assigned
Labels
ci-test-flaky put this on a PR to run concurrent workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@losfair @bartlomieju